Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOAPPX-487] Latest version of react-native-device-info #6753

Merged
merged 4 commits into from
Feb 27, 2025
Merged

chore: [IOAPPX-487] Latest version of react-native-device-info #6753

merged 4 commits into from
Feb 27, 2025

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR updates react-native-device-info to its latest version (14.0.4)

List of changes proposed in this pull request

  • react-native device info upgraded from 10.8.0 to 14.0.4
  • Ungrouped references to DeviceInfo have been moved under ts/utils/device

How to test

Using a real device, check that:

  • in the debug sections, the device id is properly displayed
  • font scale and screen lock set are properly computed on mixpanel super properties
  • device model, system version, free disk storage (ios only) are properly displayed on Zendesk permission list
  • app version is properly displayed along the app's screens (e.g., on the debug overlay)
  • when run on a tablet, the Landing screen displays the related warning

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions GitHub Actions
Copy link
Contributor

PR Title Validation for conventional commit type

✅ All good! PR title follows the conventional commit type.

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.82%. Comparing base (360de61) to head (be2d87e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/utils/device.ts 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6753   +/-   ##
=======================================
  Coverage   50.81%   50.82%           
=======================================
  Files        1579     1579           
  Lines       32601    32597    -4     
  Branches     7345     7343    -2     
=======================================
+ Hits        16567    16568    +1     
+ Misses      15991    15985    -6     
- Partials       43       44    +1
Files with missing lines Coverage Δ
...ding/biometric/checkAcknowledgedFingerprintSaga.ts 0.00% <ø> (ø)
ts/screens/authentication/LandingScreen.tsx 76.84% <100.00%> (ø)
ts/utils/appVersion.ts 93.10% <100.00%> (-0.23%) ⬇️
ts/utils/biometrics.ts 83.05% <100.00%> (+6.12%) ⬆️
ts/utils/device.ts 90.90% <75.00%> (+3.40%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3a30d1...be2d87e. Read the comment docs.

@dmnplb dmnplb changed the title chore: [IOAPPX-487] Latest version of react-native-device-info chore: [IOAPPX-487] Latest version of react-native-device-info Feb 25, 2025
LeleDallas
LeleDallas approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test one point as I don't have a tablet but the rest looks good to me!
Tested on both Android & iOS

@Vangaorth Vangaorth enabled auto-merge February 27, 2025 10:29
@shadowsheep1
Copy link
Member

shadowsheep1 commented Feb 27, 2025 •
edited
Loading

I couldn't test one point as I don't have a tablet but the rest looks good to me! Tested on both Android & iOS

Tested on Android Tablet and it works as expected.

@Vangaorth Vangaorth added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit 99a2fbc Feb 27, 2025
22 checks passed
@Vangaorth Vangaorth deleted the feature/react-native-device-info branch February 27, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeleDallas LeleDallas LeleDallas approved these changes

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

Assignees
No one assigned
Labels
Cross dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vangaorth @shadowsheep1 @LeleDallas